From 49e5d2d45857c6c340ab98f6334467607524101c Mon Sep 17 00:00:00 2001 From: Michael Czechowski Date: Mon, 19 May 2025 22:13:42 +0200 Subject: [PATCH] fix: race condition closing error feedback to early when next should appear --- src/helpers/renderer.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/helpers/renderer.js b/src/helpers/renderer.js index e13e973..e76d552 100644 --- a/src/helpers/renderer.js +++ b/src/helpers/renderer.js @@ -4,6 +4,7 @@ // Feedback elements cache let feedbackElement = null; +let feedbackTimeout = null; /** * Render the module list in the sidebar @@ -105,12 +106,7 @@ export function showFeedback(isSuccess, message) { } if (!isSuccess) { - setTimeout(() => { - if (feedbackElement && feedbackElement.parentNode) { - feedbackElement.parentNode.removeChild(feedbackElement); - } - feedbackElement = null; - }, 5_000); // Remove feedback after 3 seconds + feedbackTimeout = setTimeout(clearFeedback, 3_000); } } @@ -118,6 +114,10 @@ export function showFeedback(isSuccess, message) { * Clear any existing feedback */ export function clearFeedback() { + if (feedbackTimeout) { + clearInterval(feedbackTimeout); + } + if (feedbackElement && feedbackElement.parentNode) { feedbackElement.parentNode.removeChild(feedbackElement); }